Skip to content

Fix[2306] - Adds support for Trino UDF#2307

Merged
manticore-projects merged 2 commits intoJSQLParser:masterfrom
davyboyhayes:fix/2306
Sep 13, 2025
Merged

Fix[2306] - Adds support for Trino UDF#2307
manticore-projects merged 2 commits intoJSQLParser:masterfrom
davyboyhayes:fix/2306

Conversation

@davyboyhayes
Copy link
Contributor

@davyboyhayes davyboyhayes commented Sep 9, 2025 •
edited
Loading

Fixes #2306
Trino SQL allows you to specify User Defined functions in the WITH clause ahead of a statement. This adds support for this type of statement.

Fix[2306] - Adds support for Trino UDF
668adea 
Trino SQL allows you to specify User Defined functions in the WITH clause ahead of a statement. This adds support for this type of statement.
@davyboyhayes
Copy link
Contributor Author

davyboyhayes commented Sep 9, 2025

It's almost midnight here, so I will need to do the JMH tests in the morning (~0800 UTC)

@davyboyhayes
Copy link
Contributor Author

davyboyhayes commented Sep 10, 2025 

jmh {
    includes = ['.*JSQLParserBenchmark.*']
    warmupIterations = 2
    fork = 5
    iterations = 5
    timeOnIteration = '5s'
}

After:

  34.537 ±(99.9%) 1.669 ms/op [Average]
  (min, avg, max) = (31.524, 34.537, 36.699), stdev = 2.228
  CI (99.9%): [32.869, 36.206] (assumes normal distribution)

Before:

  36.172 ±(99.9%) 0.175 ms/op [Average]
  (min, avg, max) = (35.851, 36.172, 36.662), stdev = 0.233
  CI (99.9%): [35.997, 36.347] (assumes normal distribution)

Fix[2306] - Adds support for Trino UDF
398be70 
Trino SQL allows you to specify User Defined functions in the WITH clause ahead of a statement. This adds support for this type of statement.
@davyboyhayes
Copy link
Contributor Author

davyboyhayes commented Sep 10, 2025

I've fixed the spotbugs

@manticore-projects manticore-projects merged commit 6ce95d5 into JSQLParser:master Sep 13, 2025
2 of 3 checks passed
@manticore-projects
Copy link
Contributor

manticore-projects commented Sep 13, 2025

Thank you for your contribution!

@davyboyhayes davyboyhayes deleted the fix/2306 branch September 15, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] JSQLParser 5.4-SNAPSHOT : TRINO : WITH FUNCTION udf - unsupported

2 participants

@davyboyhayes @manticore-projects